Add ZLG-CAN and Tosun CAN device #1351
Conversation
|
from zlgcan import ZCAN, ZCANDeviceType, ZCAN_Transmit_Data, ZCAN_TransmitFD_Data, ZCAN_Receive_Data, My zlgcan file doesnot contain "ZCANDeviceType, ZCAN_Transmit_Data, ZCAN_TransmitFD_Data, ZCAN_Receive_Data, |
Please see https://github.com/zhuyu4839/zlgcan-driver |
There was a problem hiding this comment.
Thanks for the contribution to python-can!
Please add just one interface in a PR.
Please also add docs where appropriate. At a minimum add to doc/interfaces.rst and add
a new interface specific document in doc/interface/tosun and/or doc/interface/zlg.
Testing is always a good idea, hard for software that requires hardware but have a look at how other interfaces have managed it.
Suggest making this PR focus on tosun and working with @keelung-yang to take the best from this PR's zlgcan implementation and #1209.
| from can import CanInitializationError | ||
| from can.bus import LOG | ||
|
|
||
| from tosun import TSCanMessage, TSCanFdMessage, TSMasterException, TosunDevice, TSMasterMessageType |
There was a problem hiding this comment.
Suggest adding an entry for the optional dependency tosun in extras_require in setup.py.
There was a problem hiding this comment.
The ZLG-CAN device has been refactored by using rust and upload to pypi.
https://pypi.org/project/zlgcan-driver-py/
New pull requests at #1784
|
I see that your library already implements the BusABC API. You could use the plugin interface so your |
| CanInitializationError, | ||
| ) | ||
|
|
||
| from tosun import TSCanMessage, TSCanFdMessage, TSMasterException, TosunDevice, TSMasterMessageType |
There was a problem hiding this comment.
from tosun import TSCanMessage, TSCanFdMessage, TSMasterException, TosunDevice, TSMasterMessageType
How can I find/installtosunpackage?
There was a problem hiding this comment.
The tosun package is planing to be refactored by using rust
|
|
I really hope you can pr successfully, because tosun and ZLG are very popular in China😄
The package is not part of pypi, need install TSMaster software, and use it to install tosun, |
pr seems still not successful? is there have any plan? |
Add ZLG USB CAN device such as USBCANFD-200U and Tosun USB CAN device such as TC1001, TC1011, TC1004, TC1014, TC1016 etc. support. Including TSMaster COM driver